Deleting a user modal won't close and page won't redirect #6560
Conversation
When users attempted to delete their account, the form would submit but the modal would only shrink and empty instead of properly redirecting to the /users/close_account URL. This was caused by an interaction between the modal system(s) and the form submission process. This fix: - Handles the delete button click event directly - Ensures both modal systems (Mzp.Modal and $.kbox) are properly closed - Adds a small delay before programmatically submitting the form to allow modal closing to complete - Prevents the default button submission behavior to take control of the submission flow
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where the account deletion modal does not close properly and fails to redirect the page upon account deletion.
- Adds a dedicated click event handler for the delete account button
- Closes both modal systems (Mzp.Modal and $.kbox) before form submission
- Delays the form submission to allow modal closing to complete
| Mzp.Modal.closeModal(); | ||
| } | ||
|
|
||
| if ($.kbox) { |
There was a problem hiding this comment.
Consider verifying the existence of
| if ($.kbox) { | |
| if (typeof $.kbox !== 'undefined') { |
Copilot uses AI. Check for mistakes.
|
|
||
| // Directly submit the form after a small delay | ||
| // This ensures the modal closing completes before submission | ||
| setTimeout(function() { |
There was a problem hiding this comment.
Using a hardcoded delay of 50ms might be brittle if modal closing is slower than expected. Consider implementing a callback from the modal closing process or extracting the delay into a clearly named constant for easier adjustments.
Copilot uses AI. Check for mistakes.
When users attempted to delete their account, the form would submit but the modal would only shrink and empty instead of properly redirecting to the /users/close_account URL. This was caused by an interaction between the modal system(s) and the form submission process.
This fix: